More modify methods #463
Merged
More modify methods #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Feb 10, 2018
There was a problem hiding this comment.
Can you please also add a bullet point to news following http://style.tidyverse.org/news.html#during-development?
R/modify.R
Outdated
| @@ -87,6 +89,30 @@ modify.default <- function(.x, .f, ...) { | |||
| .x[] <- map(.x, .f, ...) | |||
| .x | |||
| } | |||
| #' @rdname modify | |||
| #' @export | |||
| modify.integer <- function (.x, .f, ...) { | |||
There was a problem hiding this comment.
I don’t think it’s necessary to document these individual methods - I think it makes the docs harder to understand.
|
OK, please take a look. |
|
Thanks for all your hard work on this! |
jennybc
added a commit
to tidyverse/googlesheets4
that referenced
this pull request
Apr 9, 2018
CRAN version does not preserve type of atomic vectors tidyverse/purrr#417 tidyverse/purrr#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean PR of #410 (one of these years I'll get the hang of git :)