Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict pluck #482 #522

Merged
merged 18 commits into from
Nov 27, 2018
Merged

Strict pluck #482 #522

merged 18 commits into from
Nov 27, 2018

Commits on Nov 27, 2018

  1. Add chuck() as a strict variant of pluck()

    @daniel-barnett @lionel-
    daniel-barnett authored and lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    d19e803 View commit details
    Browse the repository at this point in the history

  2. Adjust tests now that chuck() no longer auto-splices

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    ae33c46 View commit details
    Browse the repository at this point in the history

  3. Use backticks in error messages

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    ab4e5b8 View commit details
    Browse the repository at this point in the history

  4. Use "can't" instead of "must not" in error messages

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    0ce0ea8 View commit details
    Browse the repository at this point in the history

  5. Wrap branches with curly braces in extract.c

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    08f89b3 View commit details
    Browse the repository at this point in the history

  6. Use switch instead of cascading if-else

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    116a700 View commit details
    Browse the repository at this point in the history

  7. Replace "object being plucked" with "plucked object"

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    38b574e View commit details
    Browse the repository at this point in the history

  8. Rename extract.c to pluck.c

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    feed03f View commit details
    Browse the repository at this point in the history

  9. Use bool type in pluck.c

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    4027eb6 View commit details
    Browse the repository at this point in the history

  10. Extract pluck checks in separate functions

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    1e9d00f View commit details
    Browse the repository at this point in the history

  11. Use same code path as other types with NULL

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    210e670 View commit details
    Browse the repository at this point in the history

  12. Dispatch on sexptype in find_offset()

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    7dd29d8 View commit details
    Browse the repository at this point in the history

  13. Merge integer and double index code paths

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    c0384cf View commit details
    Browse the repository at this point in the history

  14. Use %d specifier instead of %i 

    The latter wrongly suggests something is going on with different
literal types
    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    50f5ba9 View commit details
    Browse the repository at this point in the history

  15. Move checking functions at end of file

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    68ad335 View commit details
    Browse the repository at this point in the history

  16. Tweak error message style

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    344bbba View commit details
    Browse the repository at this point in the history

  17. Review documentation of pluck(), chuck(), and attr_getter() 

    Closes #482
Closes #550
    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    94572ed View commit details
    Browse the repository at this point in the history

  18. Reorganise details section of ?pluck

    @lionel-
    lionel- committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    8b124ee View commit details
    Browse the repository at this point in the history