Retain dimnames in array_branch and array_tree #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a motivation for this change please? Ideally the motivation would be provided in a NEWS bullet explaining the change and would be covered by unit tests. |
|
Sure, done! |
|
OK, this looks good to go! |
lionel-
reviewed
Nov 28, 2018
lionel-
reviewed
Nov 28, 2018
flying-sheep
force-pushed
the
patch-1
branch
from
d93a851
to
da5a769
Compare
By not resetting `dim(array)` without need, the return value retains its dimnames
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not resetting
dim(array)without need, the return value retains its dimnames