Review UI of partial() #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
Dec 20, 2018
| `...f`). This also makes `partial()` more consistent with other | ||
| purrr function signatures. | ||
|
|
||
| * The `.lazy` argument of `partial()` is soft-deprecated in favour of |
NEWS.md
Outdated
| signatures. | ||
|
|
||
| * `partial()` now supports quasiquotation. When you unquote an | ||
| argument, it is evaluated once and for all. This is more flexible |
There was a problem hiding this comment.
once at function creation time ?
R/partial.R
Outdated
| #' [rlang::call_modify()] to learn more about this syntax. | ||
| #' | ||
| #' These dots support quasiquotation and quosures. If you unquote a | ||
| #' value, it is evaluated once and for all when the argument is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use quasiquotation to control timing of evaluation. Closes Extending partial() to comprehend quasiquotation #457.
Use
as_closure()to allow argument matching of primitive functions. Closes Argument matching in partial() doesn't happen for primitive functions #360.Fix infloop when partialised functions is assigned back to the same symbol. Closes option to force evaluation of supplied function in partial to avoid infinite recursion #387.
Wrap around
call_modify(). This allows user to control the position of...in the partial function signature.These changes simplify the interface and make it more flexible. The
.lazy,.env, and.firstarguments are soft-deprecated.