Add .simplify argument to accumulate() and accumulate2()
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To disable the default simplification
|
Also fixes #809 |
|
Should we allow a |
|
Closing in favour of #909. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the original implementation was based on
Reduce()we've accidentally implemented the originalaccumulate()function with automatic simplification. I think ideallyaccumulate()should always return a list and simplification would be achieved by piping intosimplify(). However that would probably be too large a breaking change. Instead,accumulate()now has a.simplifyargument to optionally disable simplification.accumulate2()gains this argument as well. The default is set toTRUEeven though it didn't use to automatically simplify. This is because consistency withaccumulate()seems more important. This is a behaviour change but I don't see any use ofaccumulate2()on CRAN. Closes #774.