Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recycle names in map2() #783

Merged
merged 4 commits into from
Aug 27, 2022
Merged

Recycle names in map2() #783

merged 4 commits into from
Aug 27, 2022

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Aug 5, 2020

Closes #779

@lionel- lionel- added the advice label Aug 5, 2020
@DavisVaughan
Copy link
Member

DavisVaughan commented Aug 5, 2020 •
edited
Loading

That should mean we get recycling for pmap() too. Maybe a test? Not sure if it is worth repeating similar tests

Also, this is another case to maybe use the R level length() callback https://github.com/tidyverse/purrr/pull/783/files#diff-ed6bf403234aac5ffa77de8c10222317R15

@hadley hadley merged commit 57aac14 into tidyverse:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
advice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recycling .x should recycle names
3 participants
@lionel- @DavisVaughan @hadley