Correctly modify with NULL values #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Aug 25, 2022
R/modify.R
Outdated
| @@ -473,3 +473,12 @@ inv_which <- function(x, sel) { | |||
| stop("unrecognised index type", call. = FALSE) | |||
| } | |||
| } | |||
|
|
|||
| `list_assign2<-` <- function(x, i, value) { | |||
There was a problem hiding this comment.
Interesting, I have never seen an assigner function like this before. Should it be called list_assigner2(), i.e. a noun? With a verb I think I'm expecting a UI like vec_assign().
There was a problem hiding this comment.
oh it should probably be list_slice2<- actually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655. Fixes #746. Fixes #753. Closes #754.
list_assign()from @DavisVaughan. Tests from @vspinu. I chose not to worry about the data frame case, as the existing error is ok.