Use tidyverse recycling rules #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Sep 7, 2022
| return out; | ||
| } | ||
| if (nx != ny && !(nx == 1 || ny == 1)) { | ||
| if (nx != ny && nx != 1 && ny != 1) { |
There was a problem hiding this comment.
Can we unclass data frames and use vec_recycle_common() instead?
There was a problem hiding this comment.
I thought about that too, but I worried (possibly needlessly) about the performance implications of now rep-ing scalars into large vectors instead. And the set of changes seemed small enough.
There was a problem hiding this comment.
I think it's fine merging as is. Just noting that in the future the rep'd scalars would become altrep repetitions so the problem would go away eventually.
Conflicts: NEWS.md
Conflicts: NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #878