Standardise list_modify() #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `NULL` now sets value * Don't recurse into non-lists Fixes #810
lionel-
approved these changes
Sep 7, 2022
| } | ||
| #' @export | ||
| #' @rdname list_modify | ||
| list_merge <- function(.x, ...) { | ||
| list_recurse(.x, list2(...), c) | ||
| y <- dots_list(..., .named = NULL, .homonyms = "error") | ||
| list_recurse(.x, y, c) |
There was a problem hiding this comment.
Should we try switching to vec_c()?
| x[[i]] <- NULL | ||
| } else if (vec_is_list(x_i) && vec_is_list(y_i)) { | ||
| list_slice2(x, i) <- list_recurse(x_i, y_i, base_f) | ||
| } else { |
There was a problem hiding this comment.
I think one thing that has always bothered me in these functions is this very flexible base case, i.e. that it accepts mismatches between lists and atoms. Should we require that the list structure of the lhs and rhs match, and fail otherwise?
There was a problem hiding this comment.
Yeah, that's a good idea. I'll explore.
There was a problem hiding this comment.
I think this is ok — it lets you override vectors with lists and vice versa:
library(purrr)
str(list_modify(list(x = list(1, 2)), x = 2))
#> List of 1
#> $ x: num 2
str(list_modify(list(x = 2), x = list(1, 2)))
#> List of 1
#> $ x:List of 2
#> ..$ : num 1
#> ..$ : num 2Created on 2022-09-07 with reprex v2.0.2
Conflicts: NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULLnow sets valueFixes #810