Use option readr.show_col_types to match the argument name

Fixes #1250
tidyverse · Jul 28, 2021 · 5ca3257 · 5ca3257
1 parent 3c46de1
commit 5ca3257
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # readr (development version)
 
+* `options(readr.show_col_types = FALSE)` now works as intended (#1250)
+
 * Avoid spurious byte compilation errors due to the programatically generated `spec_*()` functions.
 
 * `read_delim_chunked()` now again correctly respects the `chunk_size` parameter (#1248)

diff --git a/R/utils.R b/R/utils.R
@@ -28,11 +28,11 @@ show_progress <- function() {
 #' Determine whether column types should be shown
 #'
 #' Column types are shown unless
-#' - They are disabled by setting `options(readr.show_types = FALSE)`
+#' - They are disabled by setting `options(readr.show_col_types = FALSE)`
 #' - The column types are supplied with the `col_types` argument.
 #' @export
 should_show_types <- function() {
-  if (identical(getOption("readr.show_types", TRUE), FALSE)) {
+  if (identical(getOption("readr.show_col_types", TRUE), FALSE)) {
     FALSE
   } else {
     NULL

diff --git a/man/should_show_types.Rd b/man/should_show_types.Rd
diff --git a/tests/testthat/setup.R b/tests/testthat/setup.R
@@ -1,4 +1,4 @@
 pre_test_options <- options(
-  readr.show_types = FALSE,
+  readr.show_col_types = FALSE,
   readr.show_progress = FALSE
 )
diff --git a/tests/testthat/test-col-spec.R b/tests/testthat/test-col-spec.R
@@ -316,3 +316,17 @@ test_that("as.character() works on col_spec objects", {
   spec <- as.col_spec(iris)
   expect_equal(as.character(spec), "ddddf")
 })
+
+test_that("options(readr.show_col_spec) can turn off showing column specifications", {
+  options(readr.show_col_types = NULL)
+  expect_message(
+    expect_message(
+      expect_message(
+        read_csv(readr_example("mtcars.csv"))
+      )
+    )
+  )
+
+  options(readr.show_col_types = FALSE)
+  expect_silent(read_csv(readr_example("mtcars.csv")))
+})