Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid partial matching #186

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Avoid partial matching #186

merged 4 commits into from
Sep 30, 2024

Conversation

wibeasley
Copy link
Contributor

@richierocks, your SO post at https://stackoverflow.com/a/14155259/1082435 is explained well and perfect for this section. Consider replacing my explanation with a copy of your SO response.

@richierocks, your SO post at https://stackoverflow.com/a/14155259/1082435 is explained well and perfect for this section.  Consider replacing my explanation with a copy of your SO response.
syntax.Rmd Outdated
Avoid partial matching.
### Avoid partial matching

Always spell-out the complete argument names. Although the R execution tries to save you time by matching partially-completed names, do not rely on this. Partial maching is less consistent and less readable. Furthermore, the function signature may be updated in the future, and the partial match may become ambiguous.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo: "maching" -> "matching".

@richierocks
Copy link
Contributor

@wibeasley I'm happy for you to reuse text from that SO answer here, as you see fit.

@hadley
Copy link
Member

hadley commented Sep 30, 2024

I think this is good advice but what you was a bit long given the relative importance so I've reduced it a bit.

@hadley hadley merged commit e165752 into tidyverse:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants