Improved input validation #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new `check_unique_names()` * Refactor and update `check_list_of_ptypes()` and `check_list_of_functions()` * Add matching `check_list_of_bool()`
And fix arg name
And update error
| ! `values_from` must select at least one column. | ||
| ! Must select at least one item. |
There was a problem hiding this comment.
These used to report names_from vs values_from as the place where the problem came from, which was nice
There was a problem hiding this comment.
Issue: r-lib/tidyselect#327
| dplyr::filter(n > 1L) | ||
| dplyr::group_by(a, key) %>% | ||
| dplyr::summarise(n = dplyr::n(), .groups = "drop") %>% | ||
| dplyr::filter(n > 1L) |
There was a problem hiding this comment.
I think the tabbing is off? i.e. {data} shouldn't be aligned with the following lines right?
There was a problem hiding this comment.
Right, but I gave up getting cli to not re-indent.
| uncount(df, x, .id = "") | ||
| Condition | ||
| Error in `uncount()`: | ||
| ! `.id` must be a valid name or `NULL`, not the empty string "". |
There was a problem hiding this comment.
I noticed in stringr error messages you backtick the "" but we didn't do that in the rlang check functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using rlang's new
check_helpers. Fixes #1400