feat: intrinsic_evaluation_mode_visual_indicators #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g elements for eval mode
…and calibration parameters into a file, change ui elements in eval mode.
SergioReyesSan
changed the title
SergioReyesSan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The proposed features in this PR are:
Add some UI elements to the main window, indicating useful information like: speed, angles, and aspect ratio of the board, as well as indicators for the samples added according to the board size and skew angle.
Fix bugs when reading intrinsic parameter files.
Add a linearity heatmap to check the image distortion using the calibration board.
Save the training and evaluation points used for calibration and the parameters used in a file.
Loading the intrinsics file enables the evaluation mode, which, by default, modifies the elements shown on the main UI.
Related links
No related links for now.
Tests performed
Tested with rosbags that contain chessboard and dot calibration boards, however, some parameters need to be adjusted like the percentage for color transition in skew and size indicators for real-time detections.
Notes for reviewers
Some parameters need to be adjusted like the color transition for skew and size indicators for real-time detections.
Angle filtering and some extra filtering might be needed.
I have tried to delete spaces on empty lines however I might skipped some of them.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.