feat(aip_launcher): initialize parameters for new concatenate node #337
+187
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
|
xx1 gen1 test xx1gen1.mp4 |
|
@Autumn60 @TomohitoAndo If possible, we’d like to merge the PR as soon as possible. Thank you! |
7 tasks
|
x1 gen2 test
|
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
changed the title
|
@vividf |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
vividf
force-pushed
the
feat/new_concatenate_node_parameter
branch
from
4f2de83 to
470e1e0
Compare
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new concatenation algorithm with configurable parameters.
All projects using the concatenation algorithm will need updates to their parameter settings. Additionally, this is a good opportunity to have launch files load parameters from a file rather than hardcoding them in each launcher.
related link:
autowarefoundation/sample_sensor_kit_launch#108