forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ground_segmentation launch): fix ground segmentation concatenate node and timeout #1283
Merged
0x126
merged 4 commits into
tier4:beta/v0.19.1
from
badai-nguyen:beta/v0.19.1_hotfix_ground_seg_concat
May 17, 2024
Merged
fix(ground_segmentation launch): fix ground segmentation concatenate node and timeout #1283
0x126
merged 4 commits into
tier4:beta/v0.19.1
from
badai-nguyen:beta/v0.19.1_hotfix_ground_seg_concat
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
c4fbd92
to
59c182b
Compare
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
YoshiRi
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix requested part 🙇
...eption_launch/launch/obstacle_segmentation/ground_segmentation/ground_segmentation.launch.py
Outdated
Show resolved
Hide resolved
...eption_launch/launch/obstacle_segmentation/ground_segmentation/ground_segmentation.launch.py
Outdated
Show resolved
Hide resolved
YoshiRi
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yukkysaito
approved these changes
May 13, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Releated Link
Related PR: https://github.com/tier4/aip_launcher/pull/215/files
TIER IV INTERNAL LINK
Tests performed
/perception/obstacle_segmentation/concatenate_data
output (/perception/obstacle_segmentation/single_frame/pointcloud_raw
) rate: 7.2hz -> 10hzEffects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.