Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ground_segmentation launch): fix ground segmentation concatenate node and timeout #1283

Merged

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented May 2, 2024

Description

  • To add timeout in cases multi-additional lidars used for ground_segmentation

Releated Link

Tests performed

  • Tested on X2 bench hardware: /perception/obstacle_segmentation/concatenate_data output (/perception/obstacle_segmentation/single_frame/pointcloud_raw) rate: 7.2hz -> 10hz
Before After
Screenshot from 2024-05-02 11-34-36 Screenshot from 2024-05-02 09-03-38

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen changed the title v0.19.1 hotfix ground seg concat hotfix(ground_segmentation launch): fix ground segmentation concatenate time_offset & timeout May 2, 2024
@badai-nguyen badai-nguyen changed the title hotfix(ground_segmentation launch): fix ground segmentation concatenate time_offset & timeout fix(ground_segmentation launch): fix ground segmentation concatenate time_offset & timeout May 2, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the beta/v0.19.1_hotfix_ground_seg_concat branch from c4fbd92 to 59c182b Compare May 2, 2024 02:41
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as ready for review May 13, 2024 07:48
@badai-nguyen badai-nguyen changed the title fix(ground_segmentation launch): fix ground segmentation concatenate time_offset & timeout fix(ground_segmentation launch): fix ground segmentation concatenate node and timeout May 13, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix requested part 🙇

@badai-nguyen badai-nguyen requested a review from 0x126 May 13, 2024 08:30
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@0x126 0x126 merged commit afc4fd4 into tier4:beta/v0.19.1 May 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants