Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pre-commit #1287

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: fix pre-commit #1287

merged 2 commits into from
May 8, 2024

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 8, 2024

Description

https://results.pre-commit.ci/run/github/438106587/1713949692.oxOf5ClIR7GYX26o5SOXrQ
上記でエラーとなっている箇所を修正

Related links

#1272 (comment)

Tests performed

pre-commitでエラーが出ないこと

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta
Copy link
Author

h-ohta commented May 8, 2024

@ito-san 確認いただいてもよろしいでしょうか?

Copy link

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。ありがとうございます。

@ito-san ito-san merged commit ec7e474 into beta/v0.19.1 May 8, 2024
14 of 15 checks passed
@ito-san ito-san deleted the h-ohta-patch-1 branch May 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants