Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_perception_publisher): independent of pointcloud from detection_successful_rate (backport #527, #926, #1166) #290

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Feb 28, 2023

Description

autowarefoundation#1166 のbackport

単独ではconflictが発生したため、conflictが発生しないところまでさかのぼってcherry-pickを実施
autowarefoundation#527
autowarefoundation#926

Related Links

https://tier4.atlassian.net/browse/T4PB-25357

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta changed the title Backport/universe 1166 fix(dummy_perception_publisher): independent of pointcloud from detection_successful_rate (backport #527, #926, #1166) Feb 28, 2023
@h-ohta h-ohta force-pushed the backport/universe_1166 branch from e268b93 to 50265bc Compare February 28, 2023 05:31
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.14@2cd9047). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.14    #290   +/-   ##
==============================================
  Coverage                ?   5.65%           
==============================================
  Files                   ?      16           
  Lines                   ?     690           
  Branches                ?      32           
==============================================
  Hits                    ?      39           
  Misses                  ?     630           
  Partials                ?      21           
Flag Coverage Δ
differential 5.65% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta force-pushed the backport/universe_1166 branch from 50265bc to ed04ab9 Compare February 28, 2023 08:06
@h-ohta h-ohta enabled auto-merge (squash) February 28, 2023 08:06
@h-ohta h-ohta requested a review from YoheiMishina February 28, 2023 08:06
HiroIshida and others added 3 commits February 28, 2023 17:47
…using raymarchig (#527)

* Create pointcloud by raycasting from vehicle

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] Use vector of ObjectInfo

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] Implemented by strategy pattern

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* [after-review] split files

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use pcl raytracing

Tmp

Tmp

Tmp

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Add signed distance function lib

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use sdf library

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Remove no longer used functions

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Refactor

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Simplify getPoint

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Raytracing considering inter object relation

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Add random noise

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Default is object centric

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Return if no objects are detected

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Change definition of tf_global_to_local (same as other autoware codes)

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Remove create method

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Reaname: VehicleCentric -> EgoCentric

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Refactor a bit

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Tune parameter

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix: Even if selected_idices is zero, pointclouds must be published

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix launch file

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix typo

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix: create merged pointcloud when no idx is selected

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use ray-maching by default

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
…ion of dummy perception publisher (#926)

* Take advantage of visible range

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Tune

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Fix: typo

Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>

* Use hypot
…tion_successful_rate (#1166)

* fix(dummy_perception_publisher): independent of pointcloud from detection_success_rate

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@h-ohta h-ohta force-pushed the backport/universe_1166 branch from ed04ab9 to 2b4f22f Compare February 28, 2023 08:47
Copy link

@YoheiMishina YoheiMishina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ローカルで動作確認も完了しました。

@h-ohta h-ohta merged commit e9ebd09 into beta/v0.3.14 Feb 28, 2023
@h-ohta h-ohta deleted the backport/universe_1166 branch February 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants