Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dispatch release note repository #313

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

shmpwk
Copy link
Collaborator

@shmpwk shmpwk commented Mar 10, 2023

Description

This workflow triggers the repository: TIER4_INTERNAL_LINK to update the spreadsheets for release note.
The timing of this repository dispatch is

  • commit to beta branch or tag
  • commit to tier4/main default branch

Soon after this PR is merged, the above commits will trigger to write the spreadsheets

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the ci label Mar 10, 2023
@shmpwk shmpwk marked this pull request as ready for review March 10, 2023 10:21
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk
Copy link
Collaborator Author

shmpwk commented Mar 10, 2023

@kenji-miyake
I want to get agreement to add this PR from the perspective of repository management.
You don't have to check the function of this PR.

@ other system integration reviewers
As I introduced the automatic release note, this PR will automatically trigger to write spreadsheets.
(Previously, I mocked this trigger in my own repository.)

@shmpwk
Copy link
Collaborator Author

shmpwk commented Mar 10, 2023

@tkimura4
Thank you for your approval.
I think we can merge this at least with your approval.
Could you merge this since I'm not authorized to merge this pull request.

@tkimura4 tkimura4 merged commit dc16a31 into tier4:tier4/main Mar 10, 2023
@shmpwk shmpwk deleted the ci/release-note-trigger branch March 10, 2023 13:37
@shmpwk
Copy link
Collaborator Author

shmpwk commented Mar 11, 2023

@.kenji-miyake cc. @.tkimura4

I found that this workflow failed to curl because of 404 error.
https://github.com/tier4/autoware.universe/actions/runs/4385067170/jobs/7677306816

{
"message": "Not Found",
"documentation_url": "https://docs.github.com/rest/reference/repos#create-a-repository-dispatch-event"
}

On the other hands, it succeeds when I locally curl with my personal access token.

Though 404 error, it can be 401 unauthorized error because Github API seems to put 404 as unauthorized error.
https://docs.github.com/ja/rest/overview/other-authentication-methods?apiVersion=2022-11-28#basic-authentication

Here is where I curl.
https://github.com/tier4/autoware.universe/pull/313/files#diff-f07cbeb837fce9e42d15a6e254f51b38ad95d3d3a7ca048c8ee6559e61aac174R33-R39

[Question]
Could we use the current secrets.GITHUB_TOKEN as personal access token ?
If so, do you see the cause of the 404 error ?

[Edit]
I found that GITHUB_TOKEN cannot use here.
https://github.blog/changelog/2022-09-08-github-actions-use-github_token-with-workflow_dispatch-and-repository_dispatch/

To solve this problem,

  • explicitly call dispatch like the link above
  • use personal access token

mkuri pushed a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
tkimura4 pushed a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
tkimura4 pushed a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit that referenced this pull request Mar 17, 2023
* ci: dispatch release note repository (#313)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN (#315)

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* fix typo

* chore: remove white space

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
shmpwk added a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit that referenced this pull request Apr 14, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
shmpwk added a commit that referenced this pull request Apr 14, 2023
* ci: dispatch release note repository (#313)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN (#315)

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* fix typo

* chore: remove white space

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
shmpwk added a commit that referenced this pull request Apr 14, 2023
* ci: dispatch release note repository (#313)

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN (#315)

* ci(dispatch-release-note): use Github Apps instead of GIHUB_TOKEN

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* fix typo

* chore: remove white space

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants