Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trajectory_follower): fix build error in Humble #464

Merged
merged 1 commit into from
May 15, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented May 15, 2023

Description

autowarefoundation#803 を参考にビルドエラーを修正
ビルド時に出てくる以下のようなwarningについては最新でも未修正のため、今回は無視する

/home/hrkota/pilot-auto.x1.eve/src/autoware/universe/control/trajectory_follower/src/mpc.cpp:53:46: warning: use of old-style cast to ‘rcutils_duration_value_t’ {aka ‘long int’} [-Wold-style-cast]
   53 |     RCLCPP_WARN_THROTTLE(m_logger, *m_clock, 1000 /*ms*/, "fail to get Data.");
      |                                          

最新は以下
https://github.com/tier4/autoware.universe/blob/tier4/main/control/mpc_lateral_controller/src/mpc.cpp#L42

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@v-nojiri7841-esol v-nojiri7841-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ビルド時に出てくる以下のようなwarningについては最新でも未修正のため、今回は無視する
ビルドで出ているWarningはCスタイルキャストに対するものであることを確認。
無視する方針であることから修正なしでApproveする。

@h-ohta h-ohta merged commit 06de19c into beta/v0.3.16 May 15, 2023
@h-ohta h-ohta deleted the fix/trajectory_follower branch May 15, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants