Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): handle overlap lane in isEgoOutOfRoute() … #481

Merged
merged 1 commit into from
May 16, 2023

Conversation

1222-takeshi
Copy link

Description

Hotfix to beta/v0.8.0
autowarefoundation#3715

Before this change, isEgoOutOfRoute() does not work properly if the route is overlapped.
In this change, it checks the direction of the ego and goal lane.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link

FYI:
https://star4.slack.com/archives/C03QW0GU6P7/p1684156227207179

Takayuki Murooka
こちらのPRでBS地図で there are no lanelets close enough!が毎周期出るようになってしまったようです

Fumiya Watanabe
thread_ts=1684156227.207179&cid=C03QW0GU6P7)
挙動自体は問題ないのですが、lanelet::utils::query::getClosestLaneletWithConstrains() が想定していない使い方をしてるのが悪いかもしれません(ハック的な使い方をしてしまっている)。
どういう方針で修正するか少し考えます

@tkimura4 tkimura4 merged commit 2e6f19e into beta/v0.8.0 May 16, 2023
@tkimura4 tkimura4 deleted the feat/cherry-pick-3715 branch May 16, 2023 02:11
tkimura4 pushed a commit that referenced this pull request May 16, 2023
#481)

fix(behavior_path_planner): handle overlap lane in isEgoOutOfRoute() (autowarefoundation#3715)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants