Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): new framework for creating virtual wall markers (#3851) #548

Merged
merged 1 commit into from
May 31, 2023

Conversation

kyoichi-sugahara
Copy link

@kyoichi-sugahara kyoichi-sugahara commented May 31, 2023

Description

Hotfix to beta/v0.8.0
autowarefoundation#3851 PR by @maxime-clem

Tests performed

evaluator result 1699/1714
https://evaluation.tier4.jp/evaluation/reports/7342d1c0-02e2-5502-a95f-91229471ae1f?project_id=prd_jt

base line 1704/1714
https://evaluation.tier4.jp/evaluation/reports/556dbd88-0da9-5453-95cf-ce5c93eee935?project_id=prd_jt

image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…al wall markers (autowarefoundation#3851)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Patch coverage: 19.90% and project coverage change: +3.89 🎉

Comparison is base (6e09f05) 14.84% compared to head (307e373) 18.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff               @@
##           beta/v0.8.0     #548      +/-   ##
===============================================
+ Coverage        14.84%   18.73%   +3.89%     
===============================================
  Files               99      436     +337     
  Lines            11336    45570   +34234     
  Branches          6188    20581   +14393     
===============================================
+ Hits              1683     8539    +6856     
- Misses            7582    25797   +18215     
- Partials          2071    11234    +9163     
Flag Coverage Δ
differential 18.73% <19.90%> (+3.89%) ⬆️
Impacted Files Coverage Δ
common/motion_utils/src/marker/marker_helper.cpp 55.00% <ø> (ø)
.../behavior_velocity_blind_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
.../behavior_velocity_blind_spot_module/src/scene.hpp 0.00% <ø> (ø)
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_detection_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_no_stopping_area_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_occlusion_spot_module/src/debug.cpp 0.00% <0.00%> (ø)
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 0.00% <0.00%> (ø)
... and 12 more

... and 315 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit ca59285 into beta/v0.8.0 May 31, 2023
@tkimura4 tkimura4 deleted the hotfix/VirtualWallMarkerCreator branch May 31, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants