Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_planner): replace get_point function #603

Merged

Conversation

yn-mrse
Copy link

@yn-mrse yn-mrse commented Jun 22, 2023

Description

#599 および #600 をbehavior_plannerへ適用する場合、下記でredefinitionが発生する。

  • 既存のutil内関数でのredifinition
  • 既存の各scene_moduleでのredifinition

これを回避するため、既存のutil内関数を削除し、tier4_autoware_utils内の関数へ置き換える。

Related links

https://github.com/autowarefoundation/autoware.universe/pull/990/files

template <>
inline geometry_msgs::msg::Point getPoint(
const autoware_auto_planning_msgs::msg::PathPointWithLaneId & p)
{
return p.point.pose.position;
}
template <>
inline geometry_msgs::msg::Pose getPose(
const autoware_auto_planning_msgs::msg::PathPointWithLaneId & p)
{
return p.point.pose;
}

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

yn-mrse added 3 commits June 22, 2023 11:23
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
Copy link

@sfukuta sfukuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include対象のファイルを変更していますが、inculudeの内容が一致していませんが、問題ないですか?

@yn-mrse yn-mrse merged commit 6e183c3 into feat/keep_stopping_dist/v0.3.16 Jun 22, 2023
@yn-mrse yn-mrse deleted the feat/remove_util_functions/v0.3.16 branch June 22, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants