Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light): fix traffic_light_arbiter pipeline #685

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

1222-takeshi
Copy link

Description

Previously, arguments were not passed from traffic_light.launch.xml to traffic_light_arbiter.launch.xml, causing some unexpected behavior.
With the changes in this PR, that problem has been solved. The system now works as expected.

Related links

autowarefoundation#4393

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
topics.yamlの変更?
-> /perception/traffic_light_arbiter/traffic_signals
も三浦さんにお願いしても良いですか?

@tkimura4 tkimura4 merged commit 51ba02d into beta/v0.10.0 Jul 27, 2023
@tkimura4 tkimura4 deleted the hotfix/fix-traffic-light-arbiter branch July 27, 2023 05:18
@tkimura4
Copy link
Collaborator

@1222-takeshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants