This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
feat(planning_error_monitor): read params from yaml #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuki527
changed the title
kazuki527
force-pushed
the
feat/read_params_from_yaml
branch
from
98f6047 to
8f596bc
Compare
kazuki527
changed the title
h-ohta
reviewed
Apr 25, 2022
planning_launch/config/planning_diagnostics/planning_error_monitor.param.yaml
Outdated
Show resolved
Hide resolved
|
@kazuki527 Could you add units to param.yaml? |
h-ohta
approved these changes
Apr 25, 2022
takayuki5168
pushed a commit
that referenced
this pull request
May 26, 2022
* chore: remove system_error_monitor_params from sync-param-files Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * fix: remove space according to pre-commit Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp>
tzhong518
pushed a commit
that referenced
this pull request
Aug 1, 2022
* feat(planning_error_monitor): read params from yaml * fix(planning_error_monitor): fix the parameter to paramter in universe. * fix: add units of some parameters in yaml
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
autowarefoundation/autoware.universe#792
Description
Add a planning_error_monitor param yaml file.
This feature enables planning_error_monitor to read some parameters from above yaml file.
This is so that abobe parameters can be changed in other projects.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks