This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(stop_line): add ros_parameter #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp>
yukkysaito
reviewed
Jun 8, 2022
...nario_planning/lane_driving/behavior_planning/behavior_velocity_planner/stop_line.param.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp>
4 tasks
scepter914
added a commit
that referenced
this pull request
Jul 11, 2022
* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * rename Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change line Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change back to alphabetical order Signed-off-by: tkhmy <tkh.my.p@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add todo comment Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: sync files (#335) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp> * fix(perception_launch): fix vehicle param in perception launch Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: k-obitsu <56008637+k-obitsu@users.noreply.github.com>
TakumiKozaka-T4
added a commit
that referenced
this pull request
Jul 12, 2022
* chore: sync awf-latest (#322) style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync awf-latest (#325) * chore: sync files (#311) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: disable namespace `lane_start_bound` (#314) * feat: disable lane_bound * fix: lane_start_bound * feat: add center_line_arrows to disable * ci: add sync-awf.yaml (#318) * ci: add sync-awf.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * rename Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * refactor(vehicle_cmd_gate): add namespace (#316) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * style: fix flake8 C417 (#321) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore(behavior_velocity): update latest params (#320) * chore(behavior_velocity): update latest params Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * ci(pre-commit): autoupdate (#324) updates: - [github.com/tier4/pre-commit-hooks-ros: v0.7.0 → v0.7.1](tier4/pre-commit-hooks-ros@v0.7.0...v0.7.1) - [github.com/scop/pre-commit-shfmt: v3.4.3-1 → v3.5.0-1](scop/pre-commit-shfmt@v3.4.3-1...v3.5.0-1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(autoware_api_launch): add rtc controller (#305) * add rtc controller Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change line Signed-off-by: tkhmy <tkh.my.p@gmail.com> * change back to alphabetical order Signed-off-by: tkhmy <tkh.my.p@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com> * chore: sync awf-latest (#334) * chore: sync files (#327) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * refactor: virtual wall rviz config (#326) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * feat(rviz_plugin): adaptive scaling for display size (#329) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix: support context dict key for humble (#328) * fix: support context dict key for humble Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add todo comment Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: modify type of global parameter (#333) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: sync files (#335) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: use multithread for traffic light container as default (#336) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(localization_launch): fix input topic name (#338) * feat(behavior_velocity): add run out module (#339) * feat(behavior_velocity): add parameter yaml for behavior_velocity_planner Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * feat(behavior_velocity): add run out module Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(mission_planner): disable lane_start_bound in Rviz (#341) Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix(stop_line): add ros_parameter (#347) * fix(stop_line): add ros_parameter Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp> * add localization score relay node Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> * pull awf-latest Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: k-obitsu <56008637+k-obitsu@users.noreply.github.com>
takayuki5168
pushed a commit
that referenced
this pull request
Jan 21, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-obitsu koichi.obitsu@tier4.jp
PR Type
Related Links
https://tier4.atlassian.net/browse/T4PB-17592
autowarefoundation/autoware.universe#1058
Description
issues
The related issue is below.
autowarefoundation/autoware.universe#1064
The related PR is below.
autowarefoundation/autoware.universe#1058
Causes
This problem is due to the fact that after passing the stop line in manual operation, State transitions to START, but cannot transition to APPROACH.
Measures
Therefore, I will take the following measures.
・Added ros_parameter for stop_line state
・Changed the condition of if statement constexpr param to ros_param
Functional level test method
Check the following using PSim.
A route with one stop line that automatically drives the vehicle.
・After arriving at the goal, place the vehicle near the stop line. (using 2D pose estimate)
・And after the above, place the vehicle at the start point, restart the vehicle.
・Make sure to stop at the stop line.
A route with two stop line with an interval of 2m or more that automatically drives the vehicle.
・After arriving at the goal, place the vehicle near the one of stop line. (using 2D pose estimate)
・And after the above, place the vehicle at the start point, restart the vehicle.
・Make sure to stop at the both of stop line.
In addition to the above, embed the debug code so that State can be confirmed on the terminal, and confirm that State transitions as expected.
Functional level test result
I confirmed that I passed the above.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks