Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

feat: remove launch for old routing api #526

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

isamu-takagi
Copy link
Contributor

PR Type

  • Improvement

Related Links

tier4/tier4_ad_api_adaptor#75

Description

Remove launch for old routing api node.

Review Procedure

tier4/tier4_ad_api_adaptor#75

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@isamu-takagi isamu-takagi self-assigned this Oct 24, 2022
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi force-pushed the feature/ad-api/remove-old-routing-launch branch from 93d460a to 9a6b91e Compare October 24, 2022 06:43
@isamu-takagi isamu-takagi requested review from yabuta and tkhmy October 24, 2022 06:43
Copy link
Contributor

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) November 9, 2022 09:13
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wrong commend

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi changed the title Feature/ad api/remove old routing launch feat: remove launch for old routing api Nov 18, 2022
@isamu-takagi isamu-takagi merged commit 03df514 into awf-latest Nov 18, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/remove-old-routing-launch branch November 18, 2022 05:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants