Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai_decoders): implement clang-tidy fixes (mostly style-related) #183

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Aug 19, 2024

PR Type

  • Improvement

Description

This PR implements some of the suggestions and fixes from clang-tidy, in order to reduce the errors and warnings shown in the IDE. Most of these are pure style fixes.

This PR targets only hesai decoders for now.

Review Procedure

No elaborate review necessary.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz August 19, 2024 02:52
@mojomex mojomex self-assigned this Aug 19, 2024
@mojomex mojomex removed the request for review from drwnz August 19, 2024 02:52
@mojomex mojomex merged commit 5377d1c into tier4:develop Aug 19, 2024
10 checks passed
@mojomex mojomex deleted the hesai-decoders-clang-tidy-fixes branch August 19, 2024 04:19
@mojomex mojomex mentioned this pull request Aug 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant