Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude LiDAR occluded object on OccupancyGrid #1227

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

f0reachARR
Copy link
Contributor

@f0reachARR f0reachARR commented Apr 11, 2024

Description

Abstract

Partial fixes for #1193

Background

OccupancyGridSensor in simple_sensor_simulator takes detected objects from LidarSensor, but never uses it when filter_by_range is true.
This causes occluded objects (objects that were not detected) appeared in OccupancyGrid (explained in #1193).

Details

Filter objects using detected objects in getDetectedObjects method.

Before
image

After
image

As you see pictures, occluded object (tom, orange) emitted before this PR.

Reference

https://github.com/tier4/sim_evaluation_tools/issues/270

Destructive Changes

OccupancyGridSensor behavior was changed.
It emits only LiDAR detected (non occluded) objects instead of all objects in sensor range.

Known Limitations

As LiDAR origin passed to Raycaster is too low (Ego bottom), detected objects from LidarSensor contain some objects that should be occluded.
This can be observed in DetectionSensor output in #1193

Copy link

github-actions bot commented Apr 11, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test labels Apr 17, 2024
@f0reachARR f0reachARR force-pushed the fix/occluded-object-in-grid branch from 745ba9d to 99f7276 Compare April 18, 2024 05:39
@f0reachARR f0reachARR requested a review from hakuturu583 April 18, 2024 05:40
@f0reachARR f0reachARR marked this pull request as ready for review April 18, 2024 05:40
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but this pull request will changes the sensor output.
I think it is destructive change, so please describe it with sample image in pull request description.

@f0reachARR
Copy link
Contributor Author

I added two images to PR description. Thank you.

@hakuturu583 hakuturu583 merged commit b4777c8 into master Apr 18, 2024
22 checks passed
@github-actions github-actions bot deleted the fix/occluded-object-in-grid branch April 18, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants