-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude LiDAR occluded object on OccupancyGrid #1227
Conversation
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
745ba9d
to
99f7276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but this pull request will changes the sensor output.
I think it is destructive change, so please describe it with sample image in pull request description.
I added two images to PR description. Thank you. |
Description
Abstract
Partial fixes for #1193
Background
OccupancyGridSensor in simple_sensor_simulator takes detected objects from LidarSensor, but never uses it when
filter_by_range
is true.This causes occluded objects (objects that were not detected) appeared in OccupancyGrid (explained in #1193).
Details
Filter objects using detected objects in
getDetectedObjects
method.Before
After
As you see pictures, occluded object (tom, orange) emitted before this PR.
Reference
https://github.com/tier4/sim_evaluation_tools/issues/270
Destructive Changes
OccupancyGridSensor behavior was changed.
It emits only LiDAR detected (non occluded) objects instead of all objects in sensor range.
Known Limitations
As LiDAR origin passed to Raycaster is too low (Ego bottom), detected objects from LidarSensor contain some objects that should be occluded.
This can be observed in DetectionSensor output in #1193