Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ci to sync tier4/universe -> micro-bus #92

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

TomohitoAndo
Copy link
Contributor

PR Type

  • Improvement

Related Links

Description

Currently, sync tier4/universe -> micro-bus is done manually, so I added ci to sync them automatically.

Review Procedure

I will test this CI after this PR has merged.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review January 24, 2023 01:43
@TomohitoAndo TomohitoAndo requested review from yabuta and 0x126 January 24, 2023 01:43
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Jan 24, 2023

NOTE:
micro-bus branch will be deleted in the next(?) release, so I will delete this CI at the same time.

@TomohitoAndo TomohitoAndo merged commit e490986 into tier4/universe Jan 24, 2023
@TomohitoAndo TomohitoAndo deleted the add-ci-sync-micro-bus branch January 24, 2023 01:52
@TomohitoAndo
Copy link
Contributor Author

I confirmed this works.
#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants