Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Curator content since Curator is removed #1217

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

Josh-Tigera
Copy link
Contributor

@Josh-Tigera Josh-Tigera commented Dec 20, 2023

Product Version(s):

Issue:

Companion PRs:
Enterprise: https://github.com/tigera/calico-private/pull/7041
Operator: tigera/operator#3054

Link to docs preview:

https://deploy-preview-1217--calico-docs-preview-next.netlify.app/calico-enterprise/next/reference/component-versions
https://deploy-preview-1217--calico-docs-preview-next.netlify.app/calico-enterprise/next/operations/fips/#before-you-begin

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@Josh-Tigera Josh-Tigera requested a review from a team as a code owner December 20, 2023 16:07
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit cafc69a
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/659446126904cf0008da170e
😎 Deploy Preview https://deploy-preview-1217--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🟢 up 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit cafc69a
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/659446122c24ec00081c2cc3
😎 Deploy Preview https://deploy-preview-1217--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🔴 down 23 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator

Hi @Josh-Tigera . I'm not at all familiar with this one. Can you provide more context, links to tickets, etc?

@Josh-Tigera
Copy link
Contributor Author

Hi @Josh-Tigera . I'm not at all familiar with this one. Can you provide more context, links to tickets, etc?

Hi @ctauchen here is a link to the Jira issue used to track: https://tigera.atlassian.net/browse/EV-3291?atlOrigin=eyJpIjoiNTkxYmQzNmQxMWM4NGYyZWE5YWRjZWFhZDBkODhkZDciLCJwIjoiaiJ9

I have links to my operator and enterprise commits linked in the description. Basically Curator support is removed in the next version of Elasticsearch we'll be upgrading to, and currently doesn't always work the way we need it to today anyway so we're pulling the component out entirely.

Copy link
Contributor

@bmckercher123 bmckercher123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Tigera es-curator is in Calico Cloud docs as well. Should releases.json be updated in CC? Also, you have changed in root, which is 3.19/ep1. Is the change only for 3.19/ep1 and CC equivalent?

@Josh-Tigera
Copy link
Contributor Author

@Josh-Tigera es-curator is in Calico Cloud docs as well. Should releases.json be updated in CC? Also, you have changed in root, which is 3.19/ep1. Is the change only for 3.19/ep1 and CC equivalent?

Ah good catch, it should also be removed in CC so I've pushed those changes as well. The removal is not required in any particular commit so it's just whenever it goes in. I'm targeting main/master in operator and enterprise which I believe corresponds to 3.19 (unless the branch was cut already and I missed it).

@bmckercher123
Copy link
Contributor

@Josh-Tigera Please rebase to pick up dead link fixes in /main. Your PR should build after that.

@Josh-Tigera
Copy link
Contributor Author

@Josh-Tigera Please rebase to pick up dead link fixes in /main. Your PR should build after that.

@bmckercher123 I merged in an updated version of main

@bmckercher123 bmckercher123 requested a review from tmjd January 2, 2024 19:15
Copy link
Contributor

@bmckercher123 bmckercher123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmckercher123 bmckercher123 merged commit e64c288 into tigera:main Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants