Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fix: remove extra newlines from imports and fix #2911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Oct 2, 2023

Description

This creates 3 groups of imports:

  1. built-in go packages
  2. 3rd party packages
  3. tigera/projectcalico packages

each with a newline between each group

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd requested a review from a team as a code owner October 2, 2023 18:57
@marvin-tigera marvin-tigera added this to the v1.32.0 milestone Oct 2, 2023
@danudey danudey modified the milestones: v1.32.0, v1.32.1, v1.32.2 Dec 2, 2023
@danudey danudey modified the milestones: v1.32.2, v1.32.3 Dec 15, 2023
@danudey danudey modified the milestones: v1.32.3, v1.32.4 Jan 18, 2024
@radTuti radTuti modified the milestones: v1.32.4, v1.32.5, v1.32.6 Feb 16, 2024
@radTuti radTuti modified the milestones: v1.32.6, v1.32.7 Mar 25, 2024
@danudey danudey modified the milestones: v1.32.7, v1.32.8 Apr 2, 2024
@radTuti radTuti modified the milestones: v1.32.8, v1.32.9 Apr 26, 2024
@danudey danudey modified the milestones: v1.32.9, v1.32.10 Jun 14, 2024
@danudey danudey modified the milestones: v1.32.10, v1.32.11 Jul 9, 2024
@danudey danudey modified the milestones: v1.32.11, v1.32.12 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants