Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release steps: Clarify github milestone creation #3036

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Dec 4, 2023

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd tmjd force-pushed the clarify-releasing-milestone branch from adc1176 to 69654d3 Compare December 4, 2023 15:25
@tmjd tmjd merged commit 1fe6e42 into tigera:master Dec 5, 2023
@tmjd tmjd deleted the clarify-releasing-milestone branch December 5, 2023 17:29
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants