Deploy es-kube-controllers in a multi-tenant environment #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/controller/logstorage/kubecontrollers/es_kube_controllers.go
Outdated
Show resolved
Hide resolved
pkg/controller/logstorage/kubecontrollers/es_kube_controllers.go
Outdated
Show resolved
Hide resolved
pkg/controller/logstorage/kubecontrollers/es_kube_controllers.go
Outdated
Show resolved
Hide resolved
pkg/controller/logstorage/kubecontrollers/es_kube_controllers.go
Outdated
Show resolved
Hide resolved
asincu
force-pushed
the
multi_tenant_licensing
branch
3 times, most recently
from
07465e7 to
4a2e524
Compare
rene-dekker
reviewed
Feb 8, 2024
pkg/controller/logstorage/kubecontrollers/es_kube_controllers.go
Outdated
Show resolved
Hide resolved
rene-dekker
reviewed
Feb 8, 2024
rene-dekker
reviewed
Feb 8, 2024
rene-dekker
reviewed
Feb 8, 2024
asincu
force-pushed
the
multi_tenant_licensing
branch
from
4a2e524 to
11dbe5a
Compare
| if err != nil { | ||
| r.status.SetDegraded(operatorv1.ResourceReadError, "Failed to get kube controllers gateway secret", err, reqLogger) | ||
| return reconcile.Result{}, err | ||
| var kubeControllersUserSecret *core.Secret |
There was a problem hiding this comment.
This needs a comment explaining that this secret is only used for talking to es-gateway, and that when running in multi-tenant mode es-kube-controllers doesn't talk to es-gateway.
There was a problem hiding this comment.
Typo: "eskube controllers" should be "es-kube-controllers"
asincu
force-pushed
the
multi_tenant_licensing
branch
from
11dbe5a to
3dfbd5e
Compare
caseydavenport
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy es kube controllers in a tenant namespace to enable license copy in the managed clusters. We will use a new configuration
managedclusterlicensing, that only deploy the licensing controller. We also need to impersonate kube-controllers service account from calico-system namespace, since this is the one that has rights inside the managed cluster.For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.