Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Compliance namespace in Voltron's proxy targets #3145

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix the Compliance namespace in Voltron's proxy targets #3145

merged 1 commit into from
Jan 30, 2024

Conversation

rene-dekker
Copy link
Member

@rene-dekker rene-dekker commented Jan 30, 2024 •
edited
Loading

@rene-dekker rene-dekker requested a review from a team as a code owner January 30, 2024 18:19
@marvin-tigera marvin-tigera added this to the v1.33.0 milestone Jan 30, 2024
caseydavenport
caseydavenport approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wonder if we should be following this pattern for the Linseed endpoint as well since it's a bit simpler than how we've built the logic for that today.

@caseydavenport
Copy link
Member

Also suspect it would be good to have a UT for this.

@rene-dekker rene-dekker merged commit b00e770 into tigera:master Jan 30, 2024
5 checks passed
@rene-dekker rene-dekker deleted the fix-master-compliance-url branch January 30, 2024 20:14
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rene-dekker @caseydavenport @danudey @marvin-tigera