Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName to EgressGateway CRD #3190

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

mazdakn
Copy link
Member

@mazdakn mazdakn commented Feb 21, 2024

Description

Add priorityClassName field to EgressGateway resource. This is to about https://tigera.atlassian.net/browse/CORE-10148 which is a fix for https://tigera.atlassian.net/browse/CI-1312.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit db65062 into tigera:master Feb 22, 2024
5 checks passed
sridhartigera pushed a commit to sridhartigera/operator that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD
sridhartigera pushed a commit to sridhartigera/operator that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD
sridhartigera pushed a commit to sridhartigera/operator that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD
sridhartigera pushed a commit to sridhartigera/operator that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD
rene-dekker pushed a commit that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD

Co-authored-by: Erik Stidham <erik@tigera.io>
rene-dekker pushed a commit that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD

Co-authored-by: Erik Stidham <erik@tigera.io>
rene-dekker pushed a commit that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD

Co-authored-by: Erik Stidham <erik@tigera.io>
rene-dekker pushed a commit that referenced this pull request Feb 23, 2024
Add priorityClassName to EgressGateway CRD

Co-authored-by: Erik Stidham <erik@tigera.io>
@mazdakn mazdakn deleted the egw-priorityclassname branch March 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants