set mount type to DirectoryOrCreate for hostPath needed by Calico #3349
Conversation
| @@ -1082,7 +1082,7 @@ func (c *nodeComponent) nodeVolumes() []corev1.Volume { | |||
| if c.cfg.Installation.CNI.Type == operatorv1.PluginCalico { | |||
| // Determine directories to use for CNI artifacts based on the provider. | |||
| cniNetDir, cniBinDir, cniLogDir := c.cniDirectories() | |||
| volumes = append(volumes, corev1.Volume{Name: "cni-bin-dir", VolumeSource: corev1.VolumeSource{HostPath: &corev1.HostPathVolumeSource{Path: cniBinDir}}}) | |||
| volumes = append(volumes, corev1.Volume{Name: "cni-bin-dir", VolumeSource: corev1.VolumeSource{HostPath: &corev1.HostPathVolumeSource{Path: cniBinDir, Type: &dirOrCreate}}}) | |||
There was a problem hiding this comment.
I'm curious why we need this on the cni bin dir, but not the other CNI volume mounts as well?
There was a problem hiding this comment.
I think in this case, the user reporter these 3 dirs as they hit the error with these 3 ones. However, in other setups another user might hit the issue with the other paths. Now, we can either fix these 3 as we know the issue has happened and wait for other incidents, or we can add this property for all directories that we think might be affected.
It's good to be proactive and set all the really needs it, but it might needs a bit more investigation to realise which ones really needs it. WDYT?
There was a problem hiding this comment.
btw, the same question applies to calico node mounts. Maybe we should update all of them.
There was a problem hiding this comment.
@caseydavenport I don't know about the purpose of these directories. Given you know more about Calico CNI, does it make sense to set the same Type to the other directories? If so, I'll add it.
There was a problem hiding this comment.
I suppose let's leave them as is for now just to keep the changes minimal to fix the originally reported issue. I suspect these probably suffer the same problem in some cases, but we've never heard about it.
Description
Fixes: projectcalico/calico#8773
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.