Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.34] Auto pick #3381: Fix deadlock where terminating resources were never #3385

Conversation

caseydavenport
Copy link
Member

Cherry pick of #3381 on release-v1.34.

#3381: Fix deadlock where terminating resources were never

Original PR Body below

Description

Originally spotted in this comment: projectcalico/calico#8368 (comment)

The operator only removes the CNI protector finalizers on these resources when the Installation is Terminating. However, in practice there are other scenarios that might result in these resources being deleted. In those cases, we should allow the deletion to complete and immmediately recreate them. Otherwise, they will be stuck terminating forever and be left in a broken state.

Fixes projectcalico/calico#8368

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport caseydavenport requested a review from a team as a code owner June 11, 2024 18:09
@marvin-tigera marvin-tigera added this to the v1.34.0 milestone Jun 11, 2024
@caseydavenport caseydavenport merged commit faf21fd into tigera:release-v1.34 Jun 11, 2024
2 checks passed
@caseydavenport caseydavenport deleted the auto-pick-of-#3381-origin-release-v1.34 branch June 11, 2024 18:43
@danudey danudey modified the milestones: v1.34.0, v1.34.1 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants