Removed a mutual dependency between logstorage and other components if certificates are missing required key usages. #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…key usages when there is a mutual dependency between two controllers. Secrets controller is now adding internal-manager-tls to its bundle, rather than manager-tls. The internal secret is the one that is used for component-to-component authentication, while manager-tls is used for browser-to-manager TLS.
caseydavenport
approved these changes
Jul 2, 2024
rene-dekker
added a commit
that referenced
this pull request
Jul 4, 2024
…two controller rely on the (#3404) * Fix deadlock situation where two controller rely on the other to finish successfully. * Don't block controllers when the certs they are trusting are missing key usages when there is a mutual dependency between two controllers. Secrets controller is now adding internal-manager-tls to its bundle, rather than manager-tls. The internal secret is the one that is used for component-to-component authentication, while manager-tls is used for browser-to-manager TLS.
rene-dekker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this check existed already (<release-1.30). See https://github.com/tigera/operator/blob/release-v1.30/pkg/controller/logstorage/logstorage_controller.go#L491
When the controller was split up into multiple other controllers, this check slipped through the cracks, creating a mutual dependency between the logstorage controllers and other controllers like fluentd. If the fluentd, compliance, etc... secret has a bad key usage, the secret controller will result in an error. Because logstorage is not ready/available, the compliance_controller won't do anything.
Secrets controller is now adding internal-manager-tls to its bundle, rather than manager-tls. The internal secret is the one that is used for component-to-component authentication, while manager-tls is used for browser-to-manager TLS.