Dynamically add network policy for apiserver egress with configured K8SServicEndpoint #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
added
kind/bug
tomastigera
approved these changes
Sep 10, 2024
| Protocol: &networkpolicy.TCPProtocol, | ||
| Destination: calicov3.EntityRule{ | ||
| Ports: networkpolicy.Ports(1234), | ||
| Domains: []string{"k8shost"}, |
There was a problem hiding this comment.
The test took me a bit by surprise since the host is (most) often an IP 😅
There was a problem hiding this comment.
When using EKS it is a long AWS DNS name.
tmjd
force-pushed
the
policy-for-k8s-endpoint
branch
from
0d23c0b
to
fd9ea84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Enterprise, where the operator creates and manages policy to allow components to function in the presence of default deny policy, it was found that there was not appropriate allow policy when the K8s apiserver is defined with a K8SServiceEndpoint. This PR add an Egress rule to allow the needed traffic.
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.