Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use restricted namespace for opensource apiserver #3489

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

mihivagyok
Copy link
Contributor

Description

  • the opensource calico-apiserver is now running as a non-root container, however the calico-apiserver namespace has privileged labels which is not necessary
  • the calico-apiserver pods are happy with the restricted namespace label

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport
Copy link
Member

@mihivagyok we do actually need privileged PSS in some cases, specifically because in some modes of operation we run using hostNetwork: true.

I think we can adjust the PSS based on that though - if we're running with hostNet, we need privileged - otherwise, can run using restricted.

@mihivagyok
Copy link
Contributor Author

@caseydavenport Thanks, you are right, I see it now in the code. I will work on the adjustments. Thanks!

@mihivagyok
Copy link
Contributor Author

Hi @caseydavenport ! Thank you once more. I made the changes, please take a look.
Also, I would like to note that I would like cherry-pick this back to 1.34 and 1.35. Thank you very much!

@caseydavenport
Copy link
Member

LGTM, thanks @mihivagyok

@caseydavenport
Copy link
Member

/sem-approve

@marvin-tigera marvin-tigera merged commit 62b56a8 into tigera:master Sep 25, 2024
5 checks passed
mihivagyok added a commit to mihivagyok/operator that referenced this pull request Oct 2, 2024
* use restricted namespace for opensource apiserver

* when hostNetwork is required, use PSSPrivileged namespace label
mihivagyok added a commit to mihivagyok/operator that referenced this pull request Oct 2, 2024
* use restricted namespace for opensource apiserver

* when hostNetwork is required, use PSSPrivileged namespace label
mihivagyok added a commit to mihivagyok/operator that referenced this pull request Oct 2, 2024
* use restricted namespace for opensource apiserver

* when hostNetwork is required, use PSSPrivileged namespace label
tmjd added a commit that referenced this pull request Oct 22, 2024
…icted-namespace-v1.36

[Pick #3489] Use restricted namespace for opensource calico-apiserver (v1.36)
marvin-tigera added a commit that referenced this pull request Oct 28, 2024
…icted-namespace-v1.35

[Pick #3489] Use restricted namespace for opensource calico-apiserver (v1.35)
marvin-tigera added a commit that referenced this pull request Oct 28, 2024
…icted-namespace

[Pick #3489] Use restricted namespace for opensource calico-apiserver (v1.34)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants