Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introdoces SidecarWebhook status #3543

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

radixo
Copy link
Contributor

@radixo radixo commented Oct 15, 2024

Description

Introduce into ApplicationLayer CRD the SidecarWebhook status field, that will be used by the UI to determine
when deployments can be patched with WAF.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@tmjd
Copy link
Member

tmjd commented Oct 16, 2024

Please let @electricjesus review before merging this.

@tmjd tmjd merged commit 784c9a7 into tigera:master Oct 16, 2024
5 checks passed
@radixo radixo deleted the applicationlayer-status-sidecarwebhook branch October 16, 2024 13:47
radixo added a commit to radixo/operator that referenced this pull request Oct 16, 2024
radixo added a commit to radixo/operator that referenced this pull request Oct 16, 2024
electricjesus pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants