Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.5 #4

Open
wants to merge 16 commits into
base: v1.4
Choose a base branch
from
Open

V1.5 #4

wants to merge 16 commits into from

Conversation

parkererickson-tg
Copy link
Collaborator

DO NOT MERGE, only to compare diffs

Copy link
Contributor

@JosephNewmanTG JosephNewmanTG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great job! Without knowing the product 100%. I was able to follow your notes and take note of improvements. The code examples also makes sense to me.

I only have two suggestions. One for a typo and another for sentence structure and clarity.

Feel free to message me if you have any questions or concerns.

-Joseph

modules/datasets/pages/dataset_object.adoc Outdated Show resolved Hide resolved
modules/object_oriented_schema/pages/schema-def.adoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants