Next beta 🤔 #136
Next beta 🤔 #136
Conversation
…talls all over the place.
- when the --migrate-db flag is provided - when either --inertia or --livewire is provided.
# Conflicts: # app/Actions/ConfigureFrontendFramework.php # app/Actions/ValidateConfiguration.php # builds/lambo # composer.json # composer.lock # readme.md
jonsugar
changed the title
|
@mattstauffer As discussed, requesting a review. Notes: Also, I needed a way for Lambo to check which version of the config file it last updated to. I wasn't sure whether to store the data in the saved config file its self or in a separate file. In the end, I chose a separate file ~/.lambo/.last_version_update. |
|
@jonsugar Hey, how are we looking on this? Thanks! |
|
@mattstauffer I've just seen this, I wasn't receiving emails so missed it—I've updated notifications. I'll take a look tomorrow but... As far as I remember, I had completed all the tasks we had agreed on that were required for release. I think the branch is stable but since time has passed things have changed. As you noted (and have since closed) we needed to update to a version of Laravel Zero that supports PHP8. I will merge this into my branch and test it. Also, the Laravel installer no-longer uses Zips, just composer. This means there is literally no benefit to us using it–previously it was more performant. Perhaps now, we can just call composer ourselves and trap the console output like we do for other tools. Essentially, what we already do for the inertia/livewire installations. Playing devil's advocate, we could also get rid of all our custom code for Jetstream installations and just use the official installer for all installation tasks. This means less to maintain for us at the expense of not being able to trap the console output and make things pretty–not my favorite option tbh |
Woo! Reviewing now.
👌
Fine by me!
Same here. Unless the installer gets fancier and more complex over time. |
|
Ahh, I had asked you to un-do the thing where you un-dependency-injected the console writer. No worries, I'll fix that myself. |
|
Thanks for all your hard work on this @jonsugar! |
@mattstauffer Yeah, but... https://github.com/tighten/lambo/projects/2#card-46721232 |
@mattstauffer I think this is a reasonable chunk of fixes and new features to release as a beta. It should not be too big to review this time 😁 .
NOTE: the large file change count is due to the removal of
\App\Commands\LamboCommand->makeAndInvoke(). You will likely be able to skip over most of the files during the review.User facing changes
✨ Feature
Users can instruct Lambo to run database migrations. Migrations will also run automatically if the user has specified
--inertiaor--livewireas a Jetstream backed UI requires specific database tables.# database migration support 🔥 Lambo new my-side-hustle --migrate-db✨ Feature
Lambo will give the user better feedback as it executes. In prior betas it was necessary to add the
-v[vv]flag to see the commands being executed and whether they completed successfully (fixes #126).Under-the-hood changes
.envbefore migrating #121)\App\Commands\LamboCommand->makeAndInvoke().Outstanding Issues
For v1.0.0
Add
--forceoption (#123)Make opening in editor/browser configurable (#124)
Configuration improvements (#134, #119 and #109)
Issues opening the project in VS Code (#127)
Update README.md docs to reference the PHP version (#111)
For post release
Support Windows and Linux option (#117)
Add a post execution summary (#108)
Automatically add new options to ~/.lambo/config (#110)
Add a
--without-commentsoption (#85)Add new option
lambo --interactiveThis will show a menu for configuring Lambo execution (#115)
Implement
lambo edit-config --interactiveThis will show a menu for setting defaults in
~/.lambo/config(#114)