Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Remove shift for options without arguments. #24

Merged
merged 1 commit into from
Nov 10, 2016
Merged

[bugfix] Remove shift for options without arguments. #24

merged 1 commit into from
Nov 10, 2016

Conversation

milose
Copy link
Contributor

@milose milose commented Nov 10, 2016

By using shift in a while loop with options that have no arguments (ie: -d -a) it is possible for Lambo to skip an option. Example:

lambo project-name -a -d -e atom

This would run only --auth and --editor options and skip the --develop option.

@mattstauffer mattstauffer merged commit f51412b into tighten:master Nov 10, 2016
@mattstauffer
Copy link
Member

Geez, nice catch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants