-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duster #37
Add duster #37
Conversation
Great, thanks @rissajackson! I'm guessing the tests are failing because you'll have to modify the |
.github/workflows/lint.yml
Outdated
- name: Install dependencies | ||
run: composer install --no-interaction --no-suggest --ignore-platform-reqs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rissajackson - You'll probably want to double check the indentation here, but per @mattstauffer's suggestion, we'll need to add this line before the composer install
line, like this:
- name: Install dependencies | |
run: composer install --no-interaction --no-suggest --ignore-platform-reqs | |
- name: Install dependencies | |
run: | | |
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_PASSWORD }}" | |
composer install --no-interaction --no-suggest --ignore-platform-reqs |
We'll need to do the same in the tlint
job below.
.github/workflows/lint.yml
Outdated
coverage: none | ||
|
||
- name: Install dependencies | ||
run: composer install --no-interaction --no-suggest --ignore-platform-reqs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, need to add composer config
before we run composer install
.
Waiting on changes to Duster to go through before getting back to this. |
composer.json
Outdated
"laravel/nova": "*@dev", | ||
"orchestra/testbench": ">=3.6.x-dev", | ||
"phpunit/phpunit": "9.5.*", | ||
"tightenco/duster": "^0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tightenco/duster": "^0.3.1" | |
"tightenco/duster": "^0.3.2" |
.github/workflows/lint.yml
Outdated
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: 7.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php-version: 7.4 | |
php-version: 8.0 |
f0e05c3
to
24d3f0e
Compare
No description provided.