Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duster #37

Merged
merged 13 commits into from
Aug 27, 2021
Merged

Add duster #37

merged 13 commits into from
Aug 27, 2021

Conversation

rissajackson
Copy link
Contributor

No description provided.

@rissajackson rissajackson self-assigned this Aug 18, 2021
@mattstauffer
Copy link
Member

Great, thanks @rissajackson! I'm guessing the tests are failing because you'll have to modify the composer install step to account for Nova, which you can probably see an example for in the "test" GitHub action for this repo. LMK if you need any help.

Comment on lines 24 to 25
- name: Install dependencies
run: composer install --no-interaction --no-suggest --ignore-platform-reqs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rissajackson - You'll probably want to double check the indentation here, but per @mattstauffer's suggestion, we'll need to add this line before the composer install line, like this:

Suggested change
- name: Install dependencies
run: composer install --no-interaction --no-suggest --ignore-platform-reqs
- name: Install dependencies
run: |
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_PASSWORD }}"
composer install --no-interaction --no-suggest --ignore-platform-reqs

We'll need to do the same in the tlint job below.

coverage: none

- name: Install dependencies
run: composer install --no-interaction --no-suggest --ignore-platform-reqs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, need to add composer config before we run composer install.

@rissajackson
Copy link
Contributor Author

Waiting on changes to Duster to go through before getting back to this.

composer.json Outdated
"laravel/nova": "*@dev",
"orchestra/testbench": ">=3.6.x-dev",
"phpunit/phpunit": "9.5.*",
"tightenco/duster": "^0.3.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tightenco/duster": "^0.3.1"
"tightenco/duster": "^0.3.2"

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
php-version: 7.4
php-version: 8.0

@rissajackson rissajackson merged commit e1183a0 into main Aug 27, 2021
@rissajackson rissajackson deleted the rej/add-duster branch August 27, 2021 18:29
@faxblaster faxblaster mentioned this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants