Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova 4 upgrade #45

Merged
merged 2 commits into from
Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .env.testing.example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
STRIPE_TEST_KEY=
STRIPE_TEST_SECRET=
STRIPE_TEST_SECRET=sk_test_123
STRIPE_API_BASE="stripemock:12111"
28 changes: 15 additions & 13 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,28 @@ jobs:
strategy:
max-parallel: 1
matrix:
php: [7.3, 7.4, 8.0]
laravel: [6.*, 7.*, 8.*]
php: [ 8.0, 8.1 ]
laravel: [ 8.*, 9.* ]
include:
- laravel: 6.*
testbench: 4.*
phpunit: 9.*
- laravel: 7.*
testbench: 5.*
phpunit: 9.*
- laravel: 8.*
- php: 8.0
laravel: 8.*
testbench: 6.*
phpunit: 9.*
- php: 8.0
- php: 8.1
laravel: 8.*
testbench: 6.*
phpunit: 9.*

- php: 8.0
laravel: 9.*
testbench: 7.*
phpunit: 9.*
- php: 8.1
laravel: 9.*
testbench: 7.*
phpunit: 9.*
services:
stripemock:
image: stripemock/stripe-mock:latest
image: stripe/stripe-mock:v0.141.0
ports:
- 12111

Expand All @@ -49,7 +51,7 @@ jobs:

- name: Install dependencies
run: |
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_PASSWORD }}"
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_LICENSE_KEY }}"
composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" "phpunit/phpunit:${{ matrix.phpunit }}" --no-interaction --no-update
composer update --prefer-dist --no-interaction --no-progress --no-suggest

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

- name: Install dependencies
run: |
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_PASSWORD }}"
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_LICENSE_KEY }}"
composer upgrade --no-interaction --no-suggest

- name: PHP-8 compatible PHPCS
Expand All @@ -50,7 +50,7 @@ jobs:

- name: Install dependencies
run: |
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_PASSWORD }}"
composer config "http-basic.nova.laravel.com" "${{ secrets.NOVA_USERNAME }}" "${{ secrets.NOVA_LICENSE_KEY }}"
composer install --no-interaction --no-suggest

- name: Tlint Lint
Expand Down
19 changes: 16 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,22 @@ Before submitting a pull request:

To run the test suite locally:

- Run `cp .env.testing.example .env.testing` in the terminal
- Update `.env.testing` with your Stripe **test** API keys
- Run `vendor/bin/phpunit` in the terminal
- Copy the test `env` file:
```
cp .env.testing.example .env.testing
```
- Start the stripe mock docker container:
```
docker run -d --rm -it -p 12111-12112:12111-12112 --name nova-stripe-stripe-mock stripe/stripe-mock:v0.141.0
```
- Run tests:
```
./vendor/bin/phpunit
```
- When done testing your feature, be sure to stop the stripe mock container:
```
docker stop nova-stripe-stripe-mock
```

## Requirements

Expand Down
Binary file modified charges-detail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified charges-index.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 6 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,11 @@
}
],
"require": {
"php": ">=7.1.0",
"php": "^8.0|^8.1",
"stripe/stripe-php": ">=5.0"
},
"require-dev": {
"laravel/framework": ">=6.20.26",
"laravel/nova": "*@dev",
"laravel/nova": "^4.0",
"orchestra/testbench": ">=3.6.x-dev",
"phpunit/phpunit": "9.5.*",
"tightenco/duster": "^0.3.2"
Expand All @@ -54,7 +53,10 @@
}
},
"config": {
"sort-packages": true
"sort-packages": true,
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
}
},
"minimum-stability": "dev",
"prefer-stable": true
Expand Down
Binary file added customers-detail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added customers-index.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions dist/css/tool.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading