[#77] Use parent's fillables in children models #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function getFillable() | ||
| { | ||
| $parentFillable = (new ReflectionClass($this))->getParentClass()->newInstance()->getFillable(); |
There was a problem hiding this comment.
I think using the getParentClass is a bit better, that way you won't create an reflection class instance on every subsequent call to getFillable as this is cached by that method. Something like:
Suggested change
| $parentFillable = (new ReflectionClass($this))->getParentClass()->newInstance()->getFillable(); | |
| $parentClass = $this->getParentClass(); | |
| $parentFillable = (new $parentClass)->getFillable(); |
There was a problem hiding this comment.
I like this suggestion. Will definitely add it and append some tests
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information about this PR is available in issue #77