Merge pull request #348 from tighten/drift/php-83-support

Add support for PHP 8.3
tighten · Dec 1, 2023 · 3e998a4 · 3e998a4
2 parents 4d126aa + 847b69f
commit 3e998a4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu, macos, windows]
-        php: ["8.1", "8.2"]
+        php: ["8.1", "8.2", "8.3"]
         dependencies: [lowest, stable]
     steps:
       - uses: actions/checkout@v2

diff --git a/src/Formatters/NoDatesPropertyOnModels.php b/src/Formatters/NoDatesPropertyOnModels.php
@@ -25,6 +25,8 @@ class NoDatesPropertyOnModels extends BaseFormatter
 
     public const DESCRIPTION = 'Use `$casts` instead of `$dates` on Eloquent models.';
 
+    protected bool $model = false;
+
     public function format(Parser $parser, Lexer $lexer): string
     {
         $traverser = new NodeTraverser;
@@ -65,13 +67,12 @@ public function format(Parser $parser, Lexer $lexer): string
     private function nodeFinderForModelProperty(string $attribute): Closure
     {
         return function (Node $node) use ($attribute) {
-            static $model = false;
 
             if ($this->extendsAny($node, ['Model', 'Pivot', 'Authenticatable'])) {
-                $model = true;
+                $this->model = true;
             }
 
-            return $model && $node instanceof Property && (string) $node->props[0]->name === $attribute;
+            return $this->model && $node instanceof Property && (string) $node->props[0]->name === $attribute;
         };
     }
 

diff --git a/src/Linters/NoDatesPropertyOnModels.php b/src/Linters/NoDatesPropertyOnModels.php
@@ -14,16 +14,16 @@ class NoDatesPropertyOnModels extends BaseLinter
 
     public const DESCRIPTION = 'The `$dates` property was deprecated in Laravel 8. Use `$casts` instead.';
 
+    protected bool $model = false;
+
     protected function visitor(): Closure
     {
-        return function (Node $node) use (&$model) {
-            static $model = false;
-
+        return function (Node $node) {
             if ($this->extendsAny($node, ['Model', 'Pivot', 'Authenticatable'])) {
-                $model = true;
+                $this->model = true;
             }
 
-            return $model && $node instanceof Property && (string) $node->props[0]->name === 'dates';
+            return $this->model && $node instanceof Property && (string) $node->props[0]->name === 'dates';
         };
     }
 }