Remove UseAuthHelperOverFacade linter and formatter
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driftingly Yah let's just drop this one. It was Taylor's preference for a while but I think that preference has gone away. |
|
Sorry, i mean, remove this rule. |
driftingly
changed the title
UseAuthHelperOverFacade linter and formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Removing rule.
Closes #349
This PR removes the blade compiler usage from the
UseAuthHelperOverFacadelinter and formatter.The compiler runs into issues on custom blade macros. See #349
There is no way to add support for these custom macros, so I'm removing the blade compiler and support for blade code from this rule.
I would be happy if we removed this rule, I don't mind using facades.