add interpolation variable matcher #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| failure_for_should do |filepath| | ||
| "Expected #{filepath} interpolation variables to match #{default_locale_filepath}. \nProblems in:\n- " << @superset.join("\n- ") |
There was a problem hiding this comment.
I followed the pattern in another matcher file for failure_for_should
| @@ -0,0 +1,10 @@ | |||
| module I18nSpec | |||
| class Parse | |||
There was a problem hiding this comment.
I created a Parse class because this method didn't quite feel like it belonged in the LocaleFile class.
Let me know what you think
mixmix
force-pushed
the
interpolation-checker
branch
from
0e9ca6b to
470cffa
Compare
| test_value = test_translations[key] | ||
|
|
||
| test_value.nil? || | ||
| I18nSpec::Parse.for_interpolation_variables(default_value) == I18nSpec::Parse.for_interpolation_variables(test_value) |
There was a problem hiding this comment.
In this feature, I am declaring it a pass ✅ when:
A) the test locale string completely is empty / blank
OR
B) the test locale & the default locale have exactly the same interpolation variables
Is this ok?
|
@tigrish would love a merge or feedback on this when you've got time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's something I'd love to use in devise-i18n
it check interpolation keys match in translations
based on something similar I made for loomio.
Please feel free to get me to rework anything that is unclear/ verbose